]> www.infradead.org Git - users/dwmw2/linux.git/commit
ALSA: rme9652: use explicitly signed char
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 25 Oct 2022 00:03:13 +0000 (02:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:57:48 +0000 (23:57 +0900)
commit4cc7a360ec3bea1a10a1256a21c1c00fc32aaa2f
treeaf65c7d4d937d30c6a6a5880916d0c5dc6907102
parent8959092300081d01670829835f854ca8d355bd75
ALSA: rme9652: use explicitly signed char

commit 50895a55bcfde8ac6f22a37c6bc8cff506b3c7c6 upstream.

With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. This fixes warnings like:

sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned
sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)'
sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20221025000313.546261-1-Jason@zx2c4.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/rme9652/hdsp.c
sound/pci/rme9652/rme9652.c