]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf: Always feature test reallocarray
authorJames Clark <james.clark@linaro.org>
Wed, 29 Jan 2025 15:44:05 +0000 (15:44 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Fri, 31 Jan 2025 22:45:19 +0000 (14:45 -0800)
commit4c4c0724d6521a8092b7c16f8f210c5869d95b17
tree7d02de205af6c82240adec3b862fa3bc82d430c0
parent8ce0d2da14d3fb62844dd0e95982c194326b1a5f
perf: Always feature test reallocarray

This is also used in util/comm.c now, so instead of selectively doing
the feature test, always do it. If it's ever used anywhere else it's
less likely to cause another build failure.

This doesn't remove the need to manually include libc_compat.h, and
missing that will still cause an error for glibc < 2.26. There isn't a
way to fix that without poisoning reallocarray like libbpf did, but that
has other downsides like making memory debugging tools less useful. So
for Perf keep it like this and we'll have to fix up any missed includes.

Fixes the following build error:

  util/comm.c:152:31: error: implicit declaration of function
                      'reallocarray' [-Wimplicit-function-declaration]
  152 |                         tmp = reallocarray(comm_strs->strs,
      |                               ^~~~~~~~~~~~

Fixes: 13ca628716c6 ("perf comm: Add reference count checking to 'struct comm_str'")
Reported-by: Ali Utku Selen <ali.utku.selen@arm.com>
Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250129154405.777533-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/Makefile.config
tools/perf/util/comm.c