]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usb: chipidea: core: fix possible concurrent when switch role
authorXu Yang <xu.yang_2@nxp.com>
Fri, 17 Mar 2023 06:15:16 +0000 (14:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2023 10:49:24 +0000 (12:49 +0200)
commit4c1a06454f00ce3190ce78322cf05d54980f80e5
tree9cc67efaf7fe87c1acf1dbe9bfc437efbc684996
parent4e3498143863f75ecbd3d06012ed30564cbe67a0
usb: chipidea: core: fix possible concurrent when switch role

commit 451b15ed138ec15bffbebb58a00ebdd884c3e659 upstream.

The user may call role_store() when driver is handling
ci_handle_id_switch() which is triggerred by otg event or power lost
event. Unfortunately, the controller may go into chaos in this case.
Fix this by protecting it with mutex lock.

Fixes: a932a8041ff9 ("usb: chipidea: core: add sysfs group")
cc: <stable@vger.kernel.org>
Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Link: https://lore.kernel.org/r/20230317061516.2451728-2-xu.yang_2@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/ci.h
drivers/usb/chipidea/core.c
drivers/usb/chipidea/otg.c