]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ksmbd: fix a missing return value check bug
authorWentao Liang <liangwentao@iscas.ac.cn>
Mon, 23 Dec 2024 15:30:50 +0000 (23:30 +0800)
committerSteve French <stfrench@microsoft.com>
Mon, 6 Jan 2025 02:43:37 +0000 (20:43 -0600)
commit4c16e1cadcbcaf3c82d5fc310fbd34d0f5d0db7c
tree142ca01935f787c73edeead113bee9aaa8d98d04
parent9d89551994a430b50c4fffcb1e617a057fa76e20
ksmbd: fix a missing return value check bug

In the smb2_send_interim_resp(), if ksmbd_alloc_work_struct()
fails to allocate a node, it returns a NULL pointer to the
in_work pointer. This can lead to an illegal memory write of
in_work->response_buf when allocate_interim_rsp_buf() attempts
to perform a kzalloc() on it.

To address this issue, incorporating a check for the return
value of ksmbd_alloc_work_struct() ensures that the function
returns immediately upon allocation failure, thereby preventing
the aforementioned illegal memory access.

Fixes: 041bba4414cd ("ksmbd: fix wrong interim response on compound")
Signed-off-by: Wentao Liang <liangwentao@iscas.ac.cn>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c