]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fs: Fix S_NOSEC handling
authorJan Kara <jack@suse.cz>
Thu, 21 May 2015 14:05:52 +0000 (16:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2015 16:49:37 +0000 (09:49 -0700)
commit4c1215740834bef3dec9e1ef9c4f5bbe86f1f6cb
treef37f7a0b6d24fb3ce75fbaf76027eb8439117a18
parent8ed8b759437fadfd18202be9bb65a7f80c3c6d63
fs: Fix S_NOSEC handling

commit 2426f3910069ed47c0cc58559a6d088af7920201 upstream.

file_remove_suid() could mistakenly set S_NOSEC inode bit when root was
modifying the file. As a result following writes to the file by ordinary
user would avoid clearing suid or sgid bits.

Fix the bug by checking actual mode bits before setting S_NOSEC.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/inode.c