]> www.infradead.org Git - users/jedix/linux-maple.git/commit
i2c: cadence: Fix the hold bit setting
authorShubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Tue, 5 Feb 2019 11:12:53 +0000 (16:42 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 13:35:13 +0000 (14:35 +0100)
commit4bd491fd4c496589d8d9adbba3eb6d6f294baefe
treed9405e42a5fcc1937702fbe19ca6149aebca86fa
parente5f4a0bb7915d4d7f73320c57d37dde6fc16c64d
i2c: cadence: Fix the hold bit setting

[ Upstream commit d358def706880defa4c9e87381c5bf086a97d5f9 ]

In case the hold bit is not needed we are carrying the old values.
Fix the same by resetting the bit when not needed.

Fixes the sporadic i2c bus lockups on National Instruments
Zynq-based devices.

Fixes: df8eb5691c48 ("i2c: Add driver for Cadence I2C controller")
Reported-by: Kyle Roeschley <kyle.roeschley@ni.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Tested-by: Kyle Roeschley <kyle.roeschley@ni.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/busses/i2c-cadence.c