]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: google: fix unused variable warning under !CONFIG_ACPI
authorYu-Chun Lin <eleanor15x@gmail.com>
Mon, 17 Feb 2025 16:50:13 +0000 (00:50 +0800)
committerJiri Kosina <jkosina@suse.com>
Wed, 19 Feb 2025 09:04:58 +0000 (10:04 +0100)
commit4bd0725c09f377ffaf22b834241f6c050742e4fc
treeae134a93e73efe05b038c8d519fd71b731c1a3f8
parent44afc10d4678d5a3a4ab8c25750be00f037298cf
HID: google: fix unused variable warning under !CONFIG_ACPI

As reported by the kernel test robot, the following warning occurs:

>> drivers/hid/hid-google-hammer.c:261:36: warning: 'cbas_ec_acpi_ids' defined but not used [-Wunused-const-variable=]
     261 | static const struct acpi_device_id cbas_ec_acpi_ids[] = {
         |                                    ^~~~~~~~~~~~~~~~

The 'cbas_ec_acpi_ids' array is only used when CONFIG_ACPI is enabled.
Wrapping its definition and 'MODULE_DEVICE_TABLE' in '#ifdef CONFIG_ACPI'
prevents a compiler warning when ACPI is disabled.

Fixes: eb1aac4c8744f75 ("HID: google: add support tablet mode switch for Whiskers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501201141.jctFH5eB-lkp@intel.com/
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-google-hammer.c