]> www.infradead.org Git - nvme.git/commit
ftruncate: pass a signed offset
authorArnd Bergmann <arnd@arndb.de>
Wed, 19 Jun 2024 09:34:09 +0000 (11:34 +0200)
committerArnd Bergmann <arnd@arndb.de>
Mon, 24 Jun 2024 16:29:20 +0000 (18:29 +0200)
commit4b8e88e563b5f666446d002ad0dc1e6e8e7102b0
tree4a3b1870dc71d4f2d867bf0217465c451f40c2a3
parentf2661062f16b2de5d7b6a5c42a9a5c96326b8454
ftruncate: pass a signed offset

The old ftruncate() syscall, using the 32-bit off_t misses a sign
extension when called in compat mode on 64-bit architectures.  As a
result, passing a negative length accidentally succeeds in truncating
to file size between 2GiB and 4GiB.

Changing the type of the compat syscall to the signed compat_off_t
changes the behavior so it instead returns -EINVAL.

The native entry point, the truncate() syscall and the corresponding
loff_t based variants are all correct already and do not suffer
from this mistake.

Fixes: 3f6d078d4acc ("fix compat truncate/ftruncate")
Reviewed-by: Christian Brauner <brauner@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
fs/open.c
include/linux/compat.h
include/linux/syscalls.h