]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dmaengine: loongson2-apb: Change GENMASK to GENMASK_ULL
authorBinbin Zhou <zhoubinbin@loongson.cn>
Mon, 28 Oct 2024 09:34:13 +0000 (17:34 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 2 Dec 2024 17:18:57 +0000 (22:48 +0530)
commit4b65d5322e1d8994acfdb9b867aa00bdb30d177b
treeac5bff386a4643265a98b0c4554f3078713c9949
parentf0e870a0e9c5521f2952ea9f3ea9d3d122631a89
dmaengine: loongson2-apb: Change GENMASK to GENMASK_ULL

Fix the following smatch static checker warning:

drivers/dma/loongson2-apb-dma.c:189 ls2x_dma_write_cmd()
warn: was expecting a 64 bit value instead of '~(((0)) + (((~((0))) - (((1)) << (0)) + 1) & (~((0)) >> ((8 * 4) - 1 - (4)))))'

The GENMASK macro used "unsigned long", which caused build issues when
using a 32-bit toolchain because it would try to access bits > 31. This
patch switches GENMASK to GENMASK_ULL, which uses "unsigned long long".

Fixes: 71e7d3cb6e55 ("dmaengine: ls2x-apb: New driver for the Loongson LS2X APB DMA controller")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/87cdc025-7246-4548-85ca-3d36fdc2be2d@stanley.mountain/
Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://lore.kernel.org/r/20241028093413.1145820-1-zhoubinbin@loongson.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/loongson2-apb-dma.c