]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nfsd: eliminate special handling of NFS4ERR_SEQ_MISORDERED
authorJeff Layton <jlayton@kernel.org>
Sun, 9 Feb 2025 12:31:28 +0000 (07:31 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Mar 2025 13:11:03 +0000 (09:11 -0400)
commit4b54b85e38919f7a0d27ae340600ffdcf97c12d5
tree06b6f8c534805b8efe87e44570c9bbc547475f35
parent999595a651a87f4285c53710b5f600d6a141f526
nfsd: eliminate special handling of NFS4ERR_SEQ_MISORDERED

On a SEQ_MISORDERED error, the current code will reattempt the call, but
set the slot sequence ID to 1. I can find no mention of this remedy in
the spec, and it seems potentially dangerous. It's possible that the
last call was sent with seqid 1, and doing this will cause a
retransmission of the reply.

Drop this special handling, and always treat SEQ_MISORDERED like
BADSLOT. Retry the call, but leak the slot so that it is no longer used.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c