]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86: alienware-wmi-wmax: Fix awcc_hwmon_fans_init() label logic
authorKurt Borja <kuurtb@gmail.com>
Fri, 25 Apr 2025 15:45:07 +0000 (12:45 -0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 30 Apr 2025 11:05:58 +0000 (14:05 +0300)
commit4b4da10b1f7eda3c698b924ce2051d3e56e652fe
tree9c98e97260011ed9a617941ed0b6fa26c4fb7bb5
parent1fe9596a70d40b017f698db42621ec96da3a0cac
platform/x86: alienware-wmi-wmax: Fix awcc_hwmon_fans_init() label logic

To avoid passing an uninitialized `temp_id` to awcc_get_fan_label(),
pass the `fan_temps` bitmap instead, to work only on set bits.

Additionally, awcc_get_fan_label() leaves `dev` unused, so remove it
from it's signature and it does not fail, so remove error handling.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202504250521.HEkFK1Jy-lkp@intel.com/
Fixes: d69990783495 ("platform/x86: alienware-wmi-wmax: Add HWMON support")
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250425-temp-id-fix-v1-2-372d71f732bf@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/dell/alienware-wmi-wmax.c