]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm: thp: remove redundant pgtable check in set_huge_zero_page()
authorQi Zheng <zhengqi.arch@bytedance.com>
Thu, 18 Aug 2022 08:27:48 +0000 (16:27 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 26 Aug 2022 05:03:07 +0000 (22:03 -0700)
commit4b1f05fd7bfc09f433eb5a9101b781bd6c9e6de9
tree7eae7f7c86dc3fef49d377841a0441b2415436f4
parentee99c1d405606489ec66d01a7b949c49a9a2ad1a
mm: thp: remove redundant pgtable check in set_huge_zero_page()

When the pgtable is NULL in the set_huge_zero_page(), we should not
increment the count of PTE page table pages by calling mm_inc_nr_ptes().
Otherwise we may receive the following warning when the mm exits:

BUG: non-zero pgtables_bytes on freeing mm

Now we can't observe the above warning since only
do_huge_pmd_anonymous_page() invokes set_huge_zero_page() and the pgtable
can not be NULL.

Therefore, instead of moving mm_inc_nr_ptes() to the non-NULL branch of
pgtable, it is better to remove the redundant pgtable check directly.

Link: https://lkml.kernel.org/r/20220818082748.40021-1-zhengqi.arch@bytedance.com
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/huge_memory.c