]> www.infradead.org Git - users/willy/pagecache.git/commit
net: mscc: ocelot: fix memory leak on ocelot_port_add_txtstamp_skb()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 5 Dec 2024 14:55:15 +0000 (16:55 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sun, 8 Dec 2024 01:56:46 +0000 (17:56 -0800)
commit4b01bec25bef62544228bce06db6a3afa5d3d6bb
tree5fabda7585c872c21aaa256a0e2d308b5ab1ab6f
parentcdd0b9132d710d41da2e7d15af8e0da2aca7a22c
net: mscc: ocelot: fix memory leak on ocelot_port_add_txtstamp_skb()

If ocelot_port_add_txtstamp_skb() fails, for example due to a full PTP
timestamp FIFO, we must undo the skb_clone_sk() call with kfree_skb().
Otherwise, the reference to the skb clone is lost.

Fixes: 52849bcf0029 ("net: mscc: ocelot: avoid overflowing the PTP timestamp FIFO")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20241205145519.1236778-2-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mscc/ocelot_ptp.c