]> www.infradead.org Git - users/dwmw2/linux.git/commit
hwmon: (dell-smm) Fix warning on /proc/i8k creation error
authorArmin Wolf <W_Armin@gmx.de>
Fri, 12 Nov 2021 17:14:40 +0000 (18:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Dec 2021 08:19:00 +0000 (09:19 +0100)
commit4abf352f359961677d8b45bcb92e08c34a25dd3f
treeb738f90dee0606a1a84bc90d75294bcf55e9f06b
parenta501f2500fe2e54fc2b0b013b94e94dc97b73678
hwmon: (dell-smm) Fix warning on /proc/i8k creation error

commit dbd3e6eaf3d813939b28e8a66e29d81cdc836445 upstream.

The removal function is called regardless of whether
/proc/i8k was created successfully or not, the later
causing a WARN() on module removal.
Fix that by only registering the removal function
if /proc/i8k was created successfully.

Tested on a Inspiron 3505.

Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20211112171440.59006-1-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/dell-smm-hwmon.c