]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86: alienware-wmi-wmax: Fix uninitialized variable due to bad error handling
authorKurt Borja <kuurtb@gmail.com>
Wed, 16 Apr 2025 16:50:23 +0000 (13:50 -0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 17 Apr 2025 11:16:16 +0000 (14:16 +0300)
commit4a8e04e2bdcb98d513e97b039899bda03b07bcf2
treec4aa4c343993df6eb6b03d9469cec9521452e58b
parent8d6955ed76e8a47115f2ea1d9c263ee6f505d737
platform/x86: alienware-wmi-wmax: Fix uninitialized variable due to bad error handling

wmax_thermal_information() may also return -ENOMSG, which would leave
`id` uninitialized in thermal_profile_probe.

Reorder and modify logic to catch all errors.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/Z_-KVqNbD9ygvE2X@stanley.mountain
Fixes: 27e9e6339896 ("platform/x86: alienware-wmi: Refactor thermal control methods")
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250416-smatch-fix-v1-1-35491b462d8f@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/dell/alienware-wmi-wmax.c