]> www.infradead.org Git - users/sagi/libnvme.git/commit
ioctl: Rearrange members in nvme_get_features_args
authorDaniel Wagner <dwagner@suse.de>
Thu, 13 Jan 2022 14:01:08 +0000 (15:01 +0100)
committerDaniel Wagner <dwagner@suse.de>
Thu, 13 Jan 2022 17:41:01 +0000 (18:41 +0100)
commit4a1fefa39c7aef6513e98465d342233ee921b33d
treea733ea9a7595c425c782fe6dc1717e8f3557bc03
parent4cc907dd5ffeef613c1aef7fe9daeaeb7c0f88e1
ioctl: Rearrange members in nvme_get_features_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_get_features_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_get_features_sel sel;                  /*    24     4 */
        __u32                      cdw11;                /*    28     4 */
        __u32                      data_len;             /*    32     4 */
        void *                     data;                 /*    36     8 */
        __u8                       fid;                  /*    44     1 */
        __u8                       uuidx;                /*    45     1 */

        /* size: 48, cachelines: 1, members: 11 */
        /* padding: 2 */
        /* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>
src/nvme/ioctl.h