]> www.infradead.org Git - users/dwmw2/linux.git/commit
HID: wacom: Interpret tilt data from Intuos Pro BT as signed values
authorJason Gerecke <jason.gerecke@wacom.com>
Mon, 28 Oct 2024 17:39:14 +0000 (10:39 -0700)
committerJiri Kosina <jkosina@suse.com>
Wed, 6 Nov 2024 14:56:35 +0000 (15:56 +0100)
commit49a397ad24ee5e2c53a59dada2780d7e71bd3f77
treeca4658615a655ff1e359a99b89b021cd7339ff30
parent177f25d1292c7e16e1199b39c85480f7f8815552
HID: wacom: Interpret tilt data from Intuos Pro BT as signed values

The tilt data contained in the Bluetooth packets of an Intuos Pro are
supposed to be interpreted as signed values. Simply casting the values
to type `char` is not guaranteed to work since it is implementation-
defined whether it is signed or unsigned. At least one user has noticed
the data being reported incorrectly on their system. To ensure that the
data is interpreted properly, we specifically cast to `signed char`
instead.

Link: https://github.com/linuxwacom/input-wacom/issues/445
Fixes: 4922cd26f03c ("HID: wacom: Support 2nd-gen Intuos Pro's Bluetooth classic interface")
CC: stable@vger.kernel.org # 4.11+
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_wac.c