]> www.infradead.org Git - users/willy/pagecache.git/commit
NFSD: Fix CB_GETATTR status fix
authorChuck Lever <chuck.lever@oracle.com>
Mon, 10 Feb 2025 16:43:31 +0000 (11:43 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Feb 2025 18:31:28 +0000 (13:31 -0500)
commit4990d098433db18c854e75fb0f90d941eb7d479e
treecfe845fcd57b8e91e86cdd9a460f5c7009a00ba9
parent036ac2778f7b28885814c6fbc07e156ad1624d03
NFSD: Fix CB_GETATTR status fix

Jeff says:

Now that I look, 1b3e26a5ccbf is wrong. The patch on the ml was correct, but
the one that got committed is different. It should be:

    status = decode_cb_op_status(xdr, OP_CB_GETATTR, &cb->cb_status);
    if (unlikely(status || cb->cb_status))

If "status" is non-zero, decoding failed (usu. BADXDR), but we also want to
bail out and not decode the rest of the call if the decoded cb_status is
non-zero. That's not happening here, cb_seq_status has already been checked and
is non-zero, so this ends up trying to decode the rest of the CB_GETATTR reply
when it doesn't exist.

Reported-by: Jeff Layton <jlayton@kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219737
Fixes: 1b3e26a5ccbf ("NFSD: fix decoding in nfs4_xdr_dec_cb_getattr")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c