]> www.infradead.org Git - users/jedix/linux-maple.git/commit
riscv: selftests: Fix warnings pointer masking test
authorCharlie Jenkins <charlie@rivosinc.com>
Thu, 12 Dec 2024 07:01:43 +0000 (23:01 -0800)
committerPalmer Dabbelt <palmer@rivosinc.com>
Tue, 17 Dec 2024 22:23:18 +0000 (14:23 -0800)
commit498d5b14db8c9118be139f668720c67bea2dc344
tree17a05304f9bebb47fd5cb8f84f0a2578ec12c08b
parent78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
riscv: selftests: Fix warnings pointer masking test

When compiling the pointer masking tests with -Wall this warning
is present:

pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’:
pointer_masking.c:203:9: warning: ignoring return value of ‘pwrite’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
  203 |         pwrite(fd, &value, 1, 0); |
      ^~~~~~~~~~~~~~~~~~~~~~~~ pointer_masking.c:208:9: warning:
ignoring return value of ‘pwrite’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
  208 |         pwrite(fd, &value, 1, 0);

I came across this on riscv64-linux-gnu-gcc (Ubuntu
11.4.0-1ubuntu1~22.04).

Fix this by checking that the number of bytes written equal the expected
number of bytes written.

Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test")
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20241211-fix_warnings_pointer_masking_tests-v6-1-c7ae708fbd2f@rivosinc.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
tools/testing/selftests/riscv/abi/pointer_masking.c