]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sched/fair: Fix NEXT_BUDDY
authorK Prateek Nayak <kprateek.nayak@amd.com>
Thu, 28 Nov 2024 07:29:54 +0000 (12:59 +0530)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 9 Dec 2024 10:48:09 +0000 (11:48 +0100)
commit493afbd187c4c9cc1642792c0d9ba400c3d6d90d
treea2be3bced207e135f615b482af71aec9a2a2f239
parent82f9cc094975240885c93effbca7f4603f5de1bf
sched/fair: Fix NEXT_BUDDY

Adam reports that enabling NEXT_BUDDY insta triggers a WARN in
pick_next_entity().

Moving clear_buddies() up before the delayed dequeue bits ensures
no ->next buddy becomes delayed. Further ensure no new ->next buddy
ever starts as delayed.

Fixes: 152e11f6df29 ("sched/fair: Implement delayed dequeue")
Reported-by: Adam Li <adamli@os.amperecomputing.com>
Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Adam Li <adamli@os.amperecomputing.com>
Link: https://lkml.kernel.org/r/670a0d54-e398-4b1f-8a6e-90784e2fdf89@amd.com
kernel/sched/fair.c