]> www.infradead.org Git - users/jedix/linux-maple.git/commit
firmware: microchip: fix UL_IAP lock check in mpfs_auto_update_state()
authorValentina Fernandez <valentina.fernandezalanis@microchip.com>
Mon, 18 Nov 2024 15:53:54 +0000 (15:53 +0000)
committerConor Dooley <conor.dooley@microchip.com>
Thu, 5 Dec 2024 15:08:51 +0000 (15:08 +0000)
commit48808b55b07c3cea64805267a5547f03e6452a9f
treec8f848aea813dc32685af17584d05aefdc4c0853
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
firmware: microchip: fix UL_IAP lock check in mpfs_auto_update_state()

To verify that Auto Update is possible, the mpfs_auto_update_state()
function performs a "Query Security Service Request" to the system
controller.

Previously, the check was performed on the first element of the
response message, which was accessed using a 32-bit pointer. This
caused the bitwise operation to reference incorrect data, as the
response should be inspected at the byte level. Fixed this by casting
the response to a  u8 * pointer, ensuring the check correctly inspects
the appropriate byte of the response message.

Additionally, rename "UL_Auto Update" to "UL_IAP" to match the
PolarFire Family System Services User Guide.

Signed-off-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
drivers/firmware/microchip/mpfs-auto-update.c