]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 4 Apr 2016 11:40:20 +0000 (20:40 +0900)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:46:45 +0000 (15:46 -0700)
commit4847a53bf63b540a407c3c84703866cf6dcbcecb
treed467d9c48b26ab2aa1a3b6d6e54bac4273c66539
parentb76545f14356dce6dd2da8a34002bc73790b9754
usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()

Orabug: stable_rc4

[ Upstream commit 4fccb0767fdbdb781a9c5b5c15ee7b219443c89d ]

This patch fixes an issue that usbhsg_queue_done() may cause kernel
panic when dma callback is running and usb_ep_disable() is called
by interrupt handler. (Especially, we can reproduce this issue using
g_audio with usb-dmac driver.)

For example of a flow:
 usbhsf_dma_complete (on tasklet)
  --> usbhsf_pkt_handler (on tasklet)
   --> usbhsg_queue_done (on tasklet)
    *** interrupt happened and usb_ep_disable() is called ***
    --> usbhsg_queue_pop (on tasklet)
     Then, oops happened.

Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit be851fafe2b011c725e107b8b70e6ec72bcf0d05)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
drivers/usb/renesas_usbhs/mod_gadget.c