]> www.infradead.org Git - users/hch/configfs.git/commit
net: ethernet: ti: am65-cpsw: prevent WARN_ON upon module removal
authorNicolas Pitre <npitre@baylibre.com>
Fri, 4 Oct 2024 04:10:33 +0000 (00:10 -0400)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 8 Oct 2024 08:30:30 +0000 (10:30 +0200)
commit47f9605484a89ea14c41f0aa0e9294b7b94d64c0
tree402d230ff729442e7600e4125f2bca8abed7c53b
parent3dc6e998d18bfba6e0dc979d3cc68eba98dfeef7
net: ethernet: ti: am65-cpsw: prevent WARN_ON upon module removal

In am65_cpsw_nuss_remove(), move the call to am65_cpsw_unregister_devlink()
after am65_cpsw_nuss_cleanup_ndev() to avoid triggering the
WARN_ON(devlink_port->type != DEVLINK_PORT_TYPE_NOTSET) in
devl_port_unregister(). Makes it coherent with usage in
m65_cpsw_nuss_register_ndevs()'s cleanup path.

Fixes: 58356eb31d60 ("net: ti: am65-cpsw-nuss: Add devlink support")
Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/ti/am65-cpsw-nuss.c