]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ionic: Prevent tx_timeout due to frequent doorbell ringing
authorBrett Creeley <brett.creeley@amd.com>
Thu, 22 Aug 2024 19:25:57 +0000 (12:25 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 27 Aug 2024 11:22:42 +0000 (13:22 +0200)
commit4786fe29f5a0dd74d9ccdce8c734bde1fb88cf37
treecd7e5bf5acf717669215c047eee9d4e3ba17f859
parente846be0fba85603d2ad6fc8db6810958d7b6bed1
ionic: Prevent tx_timeout due to frequent doorbell ringing

With recent work to the doorbell workaround code a small hole was
introduced that could cause a tx_timeout. This happens if the rx
dbell_deadline goes beyond the netdev watchdog timeout set by the driver
(i.e. 2 seconds). Fix this by changing the netdev watchdog timeout to 5
seconds and reduce the max rx dbell_deadline to 4 seconds.

The test that can reproduce the issue being fixed is a multi-queue send
test via pktgen with the "burst" setting to 1. This causes the queue's
doorbell to be rung on every packet sent to the driver, which may result
in the device missing doorbells due to the high doorbell rate.

Cc: stable@vger.kernel.org
Fixes: 4ded136c78f8 ("ionic: add work item for missed-doorbell check")
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://patch.msgid.link/20240822192557.9089-1-brett.creeley@amd.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/pensando/ionic/ionic_dev.h
drivers/net/ethernet/pensando/ionic/ionic_lif.c