]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/xe: Fix xe_pm_runtime_get_if_active return
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 22 May 2024 17:00:59 +0000 (13:00 -0400)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 23 May 2024 15:52:56 +0000 (11:52 -0400)
commit46edb0a3eb16cebc2db6f9b6f7c19813d52bfcc9
tree0c5ac3aa08f2912bd60cd26db318fada0a667a06
parent40672b792a36894aff3a337b695f6136ee6ac5d4
drm/xe: Fix xe_pm_runtime_get_if_active return

Current callers of this function are already taking the result
to a boolean and using in an if. It might be a problem because
current function might return negative error codes on failure,
without increasing the reference counter.

In this scenario we could end up with extra 'put' call ending
in unbalanced scenarios.

Let's fix it, while aligning with the current xe_pm_get_if_in_use
style.

Tested-by: Francois Dugast <francois.dugast@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240522170105.327472-1-rodrigo.vivi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_pm.c
drivers/gpu/drm/xe/xe_pm.h