]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/xe/guc: Fix inverted logic on snapshot->copy check
authorColin Ian King <colin.i.king@gmail.com>
Wed, 9 Oct 2024 16:05:10 +0000 (17:05 +0100)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Thu, 10 Oct 2024 12:53:28 +0000 (14:53 +0200)
commit46bcb0a1214ac6677df8660ac0f6bdf1eff27e8f
treec5579b2abb7ec3deb9a6a3c3123004490c068b3a
parenta187c1b0a800565a4db6372268692aff99df7f53
drm/xe/guc: Fix inverted logic on snapshot->copy check

Currently the check to see if snapshot->copy has been allocated is
inverted and ends up dereferencing snapshot->copy when free'ing
objects in the array when it is null or not free'ing the objects
when snapshot->copy is allocated. Fix this by using the correct
non-null pointer check logic.

Fixes: d8ce1a977226 ("drm/xe/guc: Use a two stage dump for GuC logs and add more info")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241009160510.372195-1-colin.i.king@gmail.com
drivers/gpu/drm/xe/xe_guc_log.c