]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: lpfc: Remove IRQF_ONESHOT flag from threaded IRQ handling
authorJustin Tee <justin.tee@broadcom.com>
Tue, 5 Mar 2024 20:04:54 +0000 (12:04 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 10 Mar 2024 22:56:43 +0000 (18:56 -0400)
commit4623713e7ade46bfc63a3eade836f566ccbcd771
treec034b992511678fb270d6d1700a72452e37f8a7e
parent4ddf01f2f1504fa08b766e8cfeec558e9f8eef6c
scsi: lpfc: Remove IRQF_ONESHOT flag from threaded IRQ handling

IRQF_ONESHOT is found to mask HBA generated interrupts when thread_fn is
running.  As a result, some EQEs/CQEs miss timely processing resulting in
SCSI layer attempts to abort commands due to io_timeout.  Abort CQEs are
also not processed leading to the observations of hangs and spam of "0748
abort handler timed out waiting for aborting I/O" log messages.

Remove the IRQF_ONESHOT flag.  The cmpxchg and xchg atomic operations on
lpfc_queue->queue_claimed already protect potential parallel access to an
EQ/CQ should the thread_fn get interrupted by the primary irq handler.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20240305200503.57317-4-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_init.c