]> www.infradead.org Git - nvme.git/commit
md: fix bi_status reporting in md_end_clone_io
authorSong Liu <song@kernel.org>
Fri, 17 Nov 2023 23:56:30 +0000 (15:56 -0800)
committerSong Liu <song@kernel.org>
Mon, 20 Nov 2023 04:51:25 +0000 (20:51 -0800)
commit45b478951b2ba5aea70b2850c49c1aa83aedd0d2
treec55cc466698b1616ec538c285744e301feb8ce01
parente63a57303599b17290cd8bc48e6f20b24289a8bc
md: fix bi_status reporting in md_end_clone_io

md_end_clone_io() may overwrite error status in orig_bio->bi_status with
BLK_STS_OK. This could happen when orig_bio has BIO_CHAIN (split by
md_submit_bio => bio_split_to_limits, for example). As a result, upper
layer may miss error reported from md (or the device) and consider the
failed IO was successful.

Fix this by only update orig_bio->bi_status when current bio reports
error and orig_bio is BLK_STS_OK. This is the same behavior as
__bio_chain_endio().

Fixes: 10764815ff47 ("md: add io accounting for raid0 and raid5")
Cc: stable@vger.kernel.org # v5.14+
Reported-by: Bhanu Victor DiCara <00bvd0+linux@gmail.com>
Closes: https://lore.kernel.org/regressions/5727380.DvuYhMxLoT@bvd0/
Signed-off-by: Song Liu <song@kernel.org>
Tested-by: Xiao Ni <xni@redhat.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
drivers/md/md.c