]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pinctrl: samsung: fix fwnode refcount cleanup if platform_get_irq_optional() fails
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Wed, 6 Nov 2024 22:04:39 +0000 (23:04 +0100)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 2 Dec 2024 14:10:47 +0000 (15:10 +0100)
commit459915f55509f4bfd6076daa1428e28490ddee3b
treede1236e7b19416b735f3bb20ff1b29f86fd4518f
parentf686a2b52e9d78cf401f1b7f446bf0c3a81ebcc0
pinctrl: samsung: fix fwnode refcount cleanup if platform_get_irq_optional() fails

Commit 50ebd19e3585 ("pinctrl: samsung: drop pin banks references on
error paths") fixed the pin bank references on the error paths of the
probe function, but there is still an error path where this is not done.

If samsung_pinctrl_get_soc_data() does not fail, the child references
will have acquired, and they will need to be released in the error path
of platform_get_irq_optional(), as it is done in the following error
paths within the probe function.

Replace the direct return in the error path with a goto instruction to
the cleanup function.

Cc: stable@vger.kernel.org
Fixes: a382d568f144 ("pinctrl: samsung: Use platform_get_irq_optional() to get the interrupt")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241106-samsung-pinctrl-put-v1-1-de854e26dd03@gmail.com
[krzysztof: change Fixes SHA to point to commit introducing the return
 leading to OF node leak]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/pinctrl/samsung/pinctrl-samsung.c