]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf probe: Fix libdw memory leak
authorIan Rogers <irogers@google.com>
Wed, 16 Oct 2024 23:56:22 +0000 (16:56 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 17 Oct 2024 19:43:14 +0000 (12:43 -0700)
commit4585038b8e186252141ef86e9f0d8e97f11dce8d
treebd12450c4a07e05ed94a3c68d3fd7c6773284f42
parent1280f012e06e1555de47e3c3a9be898d8cbda5fb
perf probe: Fix libdw memory leak

Add missing dwarf_cfi_end to free memory associated with probe_finder
cfi_eh which is allocated and owned via a call to
dwarf_getcfi_elf. Confusingly cfi_dbg shouldn't be freed as its memory
is owned by the passed in debuginfo struct. Add comments to highlight
this.

This addresses leak sanitizer issues seen in:
tools/perf/tests/shell/test_uprobe_from_different_cu.sh

Fixes: 270bde1e76f4 ("perf probe: Search both .eh_frame and .debug_frame sections for probe location")
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Steinar H. Gunderson <sesse@google.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Hemant Kumar <hemant@linux.vnet.ibm.com>
Link: https://lore.kernel.org/r/20241016235622.52166-3-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/probe-finder.c
tools/perf/util/probe-finder.h