]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: appletb-kbd: fix "appletb_backlight" backlight device reference counting
authorQasim Ijaz <qasdev00@gmail.com>
Sun, 15 Jun 2025 22:59:41 +0000 (23:59 +0100)
committerJiri Kosina <jkosina@suse.com>
Fri, 20 Jun 2025 07:01:27 +0000 (09:01 +0200)
commit4540e41e753a7d69ecd3f5bad51fe620205c3a18
tree3440800f4fa063300f55f8c47dcff3489782614e
parentf3054152c12e2eed1e72704aff47b0ea58229584
HID: appletb-kbd: fix "appletb_backlight" backlight device reference counting

During appletb_kbd_probe, probe attempts to get the backlight device
by name. When this happens backlight_device_get_by_name looks for a
device in the backlight class which has name "appletb_backlight" and
upon finding a match it increments the reference count for the device
and returns it to the caller. However this reference is never released
leading to a reference leak.

Fix this by decrementing the backlight device reference count on removal
via put_device and on probe failure.

Fixes: 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Reviewed-by: Aditya Garg <gargaditya08@live.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-appletb-kbd.c