]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nfs/blocklayout: Report only when /no/ device is found
authorChuck Lever <chuck.lever@oracle.com>
Tue, 25 Jun 2024 20:02:07 +0000 (16:02 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 8 Jul 2024 17:47:27 +0000 (13:47 -0400)
commit450b4b3b2f742d5b3fce51e8f808ff1ed2fe9f89
tree5ea59cfbc743ff64fe789d2f26db0d3f50375dd2
parentd869da91cccb90320e101a2758f1e2b3803ade5c
nfs/blocklayout: Report only when /no/ device is found

Since commit f931d8374cad ("nfs/blocklayout: refactor block device
opening"), an error is reported when no multi-path device is found.
But this isn't a fatal error if the subsequent device open is
successful. On systems without multi-path devices, this message
always appears whether there is a problem or not.

Instead, generate less system journal noise by reporting an error
only when both open attempts fail. The new error message is more
actionable since it indicates that there is a real configuration
issue to be addressed.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/blocklayout/dev.c