]> www.infradead.org Git - users/hch/misc.git/commit
drm/xe/guc: Fix missing init value and add register order check
authorZhanjun Dong <zhanjun.dong@intel.com>
Tue, 26 Nov 2024 20:10:52 +0000 (12:10 -0800)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Tue, 3 Dec 2024 09:33:13 +0000 (10:33 +0100)
commit4495816122cc39c428ebbc4ffd30110bb2877df9
treee2ad3192fca780d42dbae1bdfcf35847196ce193
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
drm/xe/guc: Fix missing init value and add register order check

Fix missing initial value for last_value.
For GuC capture register definition, it is required to define 64bit
register in a pair of 2 consecutive 32bit register entries, low first,
then hi. Add code to check this order.

Changes from prior revs:
 v5:- Correct cross-line comment format
 v4:- Fix warn on condition and remove skipping
 v3:- Move break inside brace
 v2:- Correct the fix tag pointed commit
      Add examples in comments for warning
      Add 1 missing hi condition check

Fixes: ecb633646391 ("drm/xe/guc: Plumb GuC-capture into dev coredump")
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241126201052.1937079-1-zhanjun.dong@intel.com
(cherry picked from commit 6f59fbcfa041e7d69e5e5f39d4c8cffa06fdc50b)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
drivers/gpu/drm/xe/xe_guc_capture.c