]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cxl/core/regs: Refactor out functions to count regblocks of given type
authorHuaisheng Ye <huaisheng.ye@intel.com>
Wed, 15 Jan 2025 15:26:00 +0000 (23:26 +0800)
committerDave Jiang <dave.jiang@intel.com>
Wed, 22 Jan 2025 15:55:21 +0000 (08:55 -0700)
commit448a60e85ae2afe2cb760f5d2ed2c8a49d2bd1b4
tree21c14cb2353802d23042b2cf46fe367e9e58bf28
parent6cdbd84dc42b5f7e61c0aed67596efa0f4406a20
cxl/core/regs: Refactor out functions to count regblocks of given type

cxl_find_regblock_instance() counts the number of instances of a register
block as a side effect of searching through all available register blocks.
cxl_count_regblock() throws away that work and recounts all the register
blocks by asking cxl_find_regblock_instance() to redo work it has
already done until it finally returns an error, that is needlessly
wasteful.

Let cxl_count_regblock() leverage the counting that
cxl_find_regblock_instance() already does by passing in a sentinel value
(CXL_INSTANCES_COUNT) that triggers the count to be returned.

[ davej: Updated to more concise commit log supplied by djbw ]
[ davej: Fix up checkpatch formatting warnings ]

Signed-off-by: Huaisheng Ye <huaisheng.ye@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Link: https://patch.msgid.link/20250115152600.26482-2-huaisheng.ye@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/regs.c
drivers/cxl/cxl.h
drivers/cxl/pci.c