]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ice: remove unnecessary control queue cmd_buf arrays
authorJacob Keller <jacob.e.keller@intel.com>
Tue, 6 Aug 2024 20:46:26 +0000 (13:46 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 26 Aug 2024 16:46:14 +0000 (09:46 -0700)
commit448711c1dad080c0fc5e87d0464366f21085e98e
tree140d976bfd6dcaa261f2341c6dd05036323bbe25
parent1d95d9256cfaa3e5a1a4b3cedbd3c043df229b5a
ice: remove unnecessary control queue cmd_buf arrays

The driver allocates a cmd_buf array in addition to the desc_buf array.
This array stores an ice_sq_cd command details structure for each entry in
the control queue ring.

The contents of the structure are copied from the value passed in via
ice_sq_send_cmd, and include only a pointer to storage for the write back
descriptor contents.

Originally this array was intended to support asynchronous completion
including features such as a callback function. This support was never
implemented. All that exists today is needless copying and resetting of a
cmd_buf array that is otherwise functionally unused.

Since we do not plan to implement asynchronous completions, drop this
unnecessary memory and logic. This saves memory for each control queue, and
avoids the pointless copying and memset.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_controlq.c
drivers/net/ethernet/intel/ice/ice_controlq.h