]> www.infradead.org Git - users/dwmw2/linux.git/commit
PCI: Batch BAR sizing operations
authorAlex Williamson <alex.williamson@redhat.com>
Mon, 20 Jan 2025 18:21:59 +0000 (11:21 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 23 Jan 2025 17:05:20 +0000 (11:05 -0600)
commit4453f360862e5d9f0807941d613162c3f7a36559
tree97a4add01f845f4d78d262f562e789ba8593e852
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
PCI: Batch BAR sizing operations

Toggling memory enable is free on bare metal, but potentially expensive
in virtualized environments as the device MMIO spaces are added and
removed from the VM address space, including DMA mapping of those spaces
through the IOMMU where peer-to-peer is supported.  Currently memory
decode is disabled around sizing each individual BAR, even for SR-IOV
BARs while VF Enable is cleared.

This can be better optimized for virtual environments by sizing a set
of BARs at once, stashing the resulting mask into an array, while only
toggling memory enable once.  This also naturally improves the SR-IOV
path as the caller becomes responsible for any necessary decode disables
while sizing BARs, therefore SR-IOV BARs are sized relying only on the
VF Enable rather than toggling the PF memory enable in the command
register.

Link: https://lore.kernel.org/r/20250120182202.1878581-1-alex.williamson@redhat.com
Reported-by: Mitchell Augustin <mitchell.augustin@canonical.com>
Link: https://lore.kernel.org/r/CAHTA-uYp07FgM6T1OZQKqAdSA5JrZo0ReNEyZgQZub4mDRrV5w@mail.gmail.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Mitchell Augustin <mitchell.augustin@canonical.com>
Reviewed-by: Mitchell Augustin <mitchell.augustin@canonical.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/pci/iov.c
drivers/pci/pci.h
drivers/pci/probe.c