]> www.infradead.org Git - users/hch/xfsprogs.git/commit
xfs: fix xfs_rmap_has_other_keys usage of ECANCELED
authorDarrick J. Wong <darrick.wong@oracle.com>
Fri, 1 May 2020 21:37:08 +0000 (17:37 -0400)
committerEric Sandeen <sandeen@redhat.com>
Fri, 1 May 2020 21:37:08 +0000 (17:37 -0400)
commit443d6241db269da17e41d561b36e96cf0e5bf19e
tree0430e083f75b434857ab0d0c29a910bef065b12c
parentd6522f1d202ded4806b3d9ab7223e6595e87e2af
xfs: fix xfs_rmap_has_other_keys usage of ECANCELED

Source kernel commit: a71e4228e6f2a4fe6519d8ed081d0a164967fa31

In e7ee96dfb8c26, we converted all ITER_ABORT users to use ECANCELED
instead, but we forgot to teach xfs_rmap_has_other_keys not to return
that magic value to callers.  Fix it now by using ECANCELED both to
abort the iteration and to signal that we found another reverse mapping.
This enables us to drop the separate boolean flag.

Fixes: e7ee96dfb8c26 ("xfs: remove all *_ITER_ABORT values")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_rmap.c