]> www.infradead.org Git - users/dwmw2/linux.git/commit
bpf: Fix potential integer overflow in resolve_btfids
authorFriedrich Vock <friedrich.vock@gmx.de>
Tue, 14 May 2024 07:09:31 +0000 (09:09 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 24 May 2024 15:12:12 +0000 (17:12 +0200)
commit44382b3ed6b2787710c8ade06c0e97f5970a47c8
treeffd66a523cd4888ffba95883d30df99f22a9fb7d
parent8d00547ea8754afdc4a550af2fb7af2e3ba93cf8
bpf: Fix potential integer overflow in resolve_btfids

err is a 32-bit integer, but elf_update returns an off_t, which is 64-bit
at least on 64-bit platforms. If symbols_patch is called on a binary between
2-4GB in size, the result will be negative when cast to a 32-bit integer,
which the code assumes means an error occurred. This can wrongly trigger
build failures when building very large kernel images.

Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Signed-off-by: Friedrich Vock <friedrich.vock@gmx.de>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20240514070931.199694-1-friedrich.vock@gmx.de
tools/bpf/resolve_btfids/main.c