]> www.infradead.org Git - users/willy/xarray.git/commit
io_uring: fix corner case forgetting to vunmap
authorPavel Begunkov <asml.silence@gmail.com>
Mon, 25 Nov 2024 23:10:31 +0000 (23:10 +0000)
committerJens Axboe <axboe@kernel.dk>
Wed, 27 Nov 2024 22:00:57 +0000 (15:00 -0700)
commit43eef70e7e2ac74e7767731dd806720c7fb5e010
tree52d6f5b19f36d65f744b1c5a5ebc23bb7bf8e94f
parent49c5c63d48eb5b110580e4c4b937f0006fcc9b10
io_uring: fix corner case forgetting to vunmap

io_pages_unmap() is a bit tricky in trying to figure whether the pages
were previously vmap'ed or not. In particular If there is juts one page
it belives there is no need to vunmap. Paired io_pages_map(), however,
could've failed io_mem_alloc_compound() and attempted to
io_mem_alloc_single(), which does vmap, and that leads to unpaired vmap.

The solution is to fail if io_mem_alloc_compound() can't allocate a
single page. That's the easiest way to deal with it, and those two
functions are getting removed soon, so no need to overcomplicate it.

Cc: stable@vger.kernel.org
Fixes: 3ab1db3c6039e ("io_uring: get rid of remap_pfn_range() for mapping rings/sqes")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/477e75a3907a2fe83249e49c0a92cd480b2c60e0.1732569842.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/memmap.c