]> www.infradead.org Git - users/dwmw2/linux.git/commit
gpio: mt7621: report failure of devm_kasprintf()
authorNicholas Mc Guire <hofrat@osadl.org>
Wed, 21 Nov 2018 18:06:12 +0000 (19:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 19:02:15 +0000 (20:02 +0100)
commit43902c262b128a97d76ea77db66b3ce4ef46ece5
tree0f170c936d152ce0529b3c09f67387a713debe9b
parent4dc2acb15d52af484ee1155aee9ae53474827647
gpio: mt7621: report failure of devm_kasprintf()

[ Upstream commit 59d646c775d6ae688ee90fda9f2a4270c47b7490 ]

kasprintf() may return NULL on failure of internal allocation thus the
assigned  label  is not safe if not explicitly checked. On error
mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the
(unlikely) failure case should be fine here.

Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Sean Wang <sean.wang@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-mt7621.c