]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: hisi_sas: Create trigger_dump at the end of the debugfs initialization
authorYihang Li <liyihang9@huawei.com>
Tue, 8 Oct 2024 02:18:11 +0000 (10:18 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 16 Oct 2024 02:33:34 +0000 (22:33 -0400)
commit436a97c5d2882c09f44d3255ac47f641860faeea
treee9ab2d6fc3533b2ff9acfb5bfa2658ff274a88a0
parente6702e3919328b24757872cbf7f02c51894624d7
scsi: hisi_sas: Create trigger_dump at the end of the debugfs initialization

In the current debugfs initialization process, the interface
trigger_dump is created first, and then the dump directory is created to
store the register dump information.

The issue is that after the trigger_dump interface is created, users can
access the interface to trigger dump and call
debugfs_create_files_v3_hw().  In debugfs_create_files_v3_hw(), if
.debugfs_dump_dentry is NULL, the file for storing dump information is
created under /sys/kernel/debug, and the memory and information cannot
be released after the driver is uninstalled.

Therefore, the creation of the trigger_dump interface is placed at the
end of debugfs initialization.

Signed-off-by: Yihang Li <liyihang9@huawei.com>
Link: https://lore.kernel.org/r/20241008021822.2617339-3-liyihang9@huawei.com
Reviewed-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c