]> www.infradead.org Git - users/jedix/linux-maple.git/commit
x86/ioapic: Add register level checks to detect bogus io-apic entries
authorSuresh Siddha <suresh.b.siddha@intel.com>
Mon, 12 Mar 2012 18:36:33 +0000 (11:36 -0700)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Thu, 12 Apr 2012 22:14:36 +0000 (15:14 -0700)
commit42af242e5687c0522154800c3bbd6d0a73a35d2a
tree8ac11778a9e8ee82782333c892d48d735d68c490
parente170255de647cca185730db2c510f3904e3c37f6
x86/ioapic: Add register level checks to detect bogus io-apic entries

commit 73d63d038ee9f769f5e5b46792d227fe20e442c5 upstream.

With the recent changes to clear_IO_APIC_pin() which tries to
clear remoteIRR bit explicitly, some of the users started to see
"Unable to reset IRR for apic .." messages.

Close look shows that these are related to bogus IO-APIC entries
which return's all 1's for their io-apic registers. And the
above mentioned error messages are benign. But kernel should
have ignored such io-apic's in the first place.

Check if register 0, 1, 2 of the listed io-apic are all 1's and
ignore such io-apic.

Reported-by: Álvaro Castillo <midgoon@gmail.com>
Tested-by: Jon Dufresne <jon@jondufresne.org>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: yinghai@kernel.org
Cc: kernel-team@fedoraproject.org
Cc: Josh Boyer <jwboyer@redhat.com>
Link: http://lkml.kernel.org/r/1331577393.31585.94.camel@sbsiddha-desk.sc.intel.com
[ Performed minor cleanup of affected code. ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/kernel/apic/io_apic.c