]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ufs_free_fragments(): fix the braino in sanity check
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 18 Oct 2024 07:25:29 +0000 (03:25 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 18 Oct 2024 21:35:31 +0000 (17:35 -0400)
commit426f07ad3e2c9b51bfd93b870a3a9b04644130d0
tree950c25205efbb13d0018dbdf268ccff1e2124bdb
parentc5df105f7da3448129b120da7dba765bc64ddb62
ufs_free_fragments(): fix the braino in sanity check

The function expects that all fragments it's been asked to free will
be within the same block.  And it even has a sanity check verifying
that - it takes the fragment number modulo the number of fragments
per block, adds the count and checks if that's too high.

Unfortunately, it misspells the upper limit - instead of ->s_fpb
(fragments per block) it says ->s_fpg (fragments per cylinder group).
So "too high" ends up being insanely lenient.

Had been that way since 2.1.112, when UFS write support had been
added.  27 years to spot a typo...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ufs/balloc.c