]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config
authorGabor Juhos <j4g8y7@gmail.com>
Mon, 28 Oct 2024 18:48:16 +0000 (19:48 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 26 Dec 2024 22:43:03 +0000 (16:43 -0600)
commit41c5ebfb9b4b42b1479f16a50d96146fa945abce
treeb0dcd1d95a34e98a30fe0230838bec2676c873b1
parent3e632d9c33d8a4f0d8f98e69b56bd2f2145d91c4
clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config

Since neither 'alpha' nor 'alpha_hi' is defined in the configuration,
those will be initialized with zero values implicitly. By using zero
alpha values, the output rate of the PLL will be the same whether
alpha mode is enabled or not.

Remove the superfluous initialization of the 'alpha_en_mask' member
to make it clear that enabling alpha mode is not required to get the
desired output rate.

Despite that enabling alpha mode is not needed for the initial
configuration, the set_rate() op might require that it is enabled
already. In this particular case however, the
clk_alpha_pll_stromer_plus_set_rate() function will get reset the
ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask'
is safe.

While at it, also add a comment to indicate the frequency the PLL
runs at with the current configuration.

No functional changes, the initial rate of the PLL is the same both
before and after the patch.

Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board).

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://lore.kernel.org/r/20241028-alpha-mode-cleanup-v2-2-9bc6d712bd76@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/apss-ipq-pll.c