]> www.infradead.org Git - users/dwmw2/linux.git/commit
exec: move warning of null argv to be next to the relevant code
authornir@lichtman.org <nir@lichtman.org>
Sat, 2 Nov 2024 12:01:22 +0000 (14:01 +0200)
committerKees Cook <kees@kernel.org>
Sat, 30 Nov 2024 03:35:58 +0000 (19:35 -0800)
commit4188fc31a95e6c7a03c5859831d48ce646b26e46
tree2e36ee4dbc0dc5ab4d46e618718d01dce94a0933
parentb6709dcd87ac85d56e7cd574a7b21f3a8727d942
exec: move warning of null argv to be next to the relevant code

Problem: The warning is currently printed where it is detected that the
arg count is zero but the action is only taken place later in the flow
even though the warning is written as if the action is taken place in
the time of print

This could be problematic since there could be a failure between the
print and the code that takes action which would deem this warning
misleading

Solution: Move the warning print after the action of adding an empty
string as the first argument is successful

Signed-off-by: Nir Lichtman <nir@lichtman.org>
Link: https://lore.kernel.org/r/ZyYUgiPc8A8i_3FH@nirs-laptop.
Signed-off-by: Kees Cook <kees@kernel.org>
fs/exec.c