]> www.infradead.org Git - users/hch/xfstests-dev.git/commit
tests: _fail on _scratch_mkfs_sized failure
authorDavid Disseldorp <ddiss@suse.de>
Mon, 29 Apr 2024 15:37:52 +0000 (01:37 +1000)
committerZorro Lang <zlang@kernel.org>
Sun, 12 May 2024 12:28:48 +0000 (20:28 +0800)
commit41474afbed5b3a215061c81815c83323d3d2accc
treec0536bb96916949bfda9a2bfb9f57a97ad160f55
parentb26d68da08e47e6508a96bee72b25823040ab67e
tests: _fail on _scratch_mkfs_sized failure

If _scratch_mkfs_sized() fails, e.g. due to an FS not supporting the
provided size, tests may subsequently mount and run atop a previously
created (e.g. non-size-bound) filesystem.
This can lead to difficult to debug failures, or for some -ENOSPC
exercising tests, near infinite runtimes. Avoid this by renaming the
current function to _try_scratch_mkfs_sized() and _fail in the parent
_scratch_mkfs_sized() wrapper.

[zlang: change _fail output, remove missed _fail in b/007, fix g/466]

Suggested-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>
16 files changed:
common/rc
tests/btrfs/004
tests/btrfs/007
tests/ext4/021
tests/ext4/059
tests/generic/015
tests/generic/077
tests/generic/083
tests/generic/171
tests/generic/172
tests/generic/173
tests/generic/174
tests/generic/466
tests/generic/735
tests/xfs/015
tests/xfs/057