]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usbnet: asix AX88772: leave the carrier control to phylink
authorKrzysztof Hałasa <khalasa@piap.pl>
Tue, 8 Apr 2025 11:59:41 +0000 (13:59 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Apr 2025 01:42:50 +0000 (18:42 -0700)
commit4145f00227ee80f21ab274e9cd9c09758e9bcf3d
tree92b40bc4ae2ff8aecfc1182c712ce5c48539d0e3
parent8127837aae8f63ec30fcba7f5afd4887f83111cd
usbnet: asix AX88772: leave the carrier control to phylink

ASIX AX88772B based USB 10/100 Ethernet adapter doesn't come
up ("carrier off"), despite the built-in 100BASE-FX PHY positive link
indication. The internal PHY is configured (using EEPROM) in fixed
100 Mbps full duplex mode.

The primary problem appears to be using carrier_netif_{on,off}() while,
at the same time, delegating carrier management to phylink. Use only the
latter and remove "manual control" in the asix driver.

I don't have any other AX88772 board here, but the problem doesn't seem
specific to a particular board or settings - it's probably
timing-dependent.

Remove unused asix_adjust_link() as well.

Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/m3plhmdfte.fsf_-_@t19.piap.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/asix.h
drivers/net/usb/asix_common.c
drivers/net/usb/asix_devices.c