]> www.infradead.org Git - users/dwmw2/linux.git/commit
mt76: mt7615: Use after free in mt7615_mcu_set_bcn()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 3 May 2019 13:09:13 +0000 (16:09 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Sep 2019 07:11:03 +0000 (09:11 +0200)
commit4111a1f2142e5fb669c53136c935cad48159bfcc
tree712e1157e16be3d566376a2cde5df647dccf924b
parent195d154b8a711ee27fc7337a6988ce9acb66b73b
mt76: mt7615: Use after free in mt7615_mcu_set_bcn()

commit 9db1aec0c2d72a3b7b115ba56e8dbb5b46855333 upstream.

We dereference "skb" when we assign:

req.pkt_len = cpu_to_le16(MT_TXD_SIZE + skb->len);
                                                ^^^^^^^^
So this patch just moves the dev_kfree_skb() down a bit to avoid the
use after free.

Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c