]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: adc: adi-axi-adc: improve probe() error messaging
authorTrevor Gamblin <tgamblin@baylibre.com>
Thu, 13 Jun 2024 16:34:06 +0000 (12:34 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 22 Jun 2024 09:48:48 +0000 (10:48 +0100)
commit40c0f07528c795b83abb4550a16b7866c6db5778
treec71e266ee8d81378eb871f16f0401026f8f91812
parent20460472952043a4735e9abc1fd9de8e024d1c9e
iio: adc: adi-axi-adc: improve probe() error messaging

The current error handling for calls such as devm_clk_get_enabled() in
the adi-axi-adc probe() function means that, if a property such as
'clocks' (for example) is not present in the devicetree when booting a
kernel with the driver enabled, the resulting error message will be
vague, e.g.:

|adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with error -2

Change the devm_clk_get_enabled(), devm_regmap_init_mmio(), and
devm_iio_backend_register() checks to use dev_err_probe() with some
context for easier debugging.

After the change:

|adi_axi_adc 44a00000.backend: error -ENOENT: failed to get clock
|adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with error -2

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20240613163407.2147884-1-tgamblin@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/adi-axi-adc.c