]> www.infradead.org Git - users/hch/blktests.git/commit
block/008: avoid _offline_cpu() call in sub-shell
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Mon, 4 Jul 2022 11:16:38 +0000 (20:16 +0900)
committerShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Wed, 27 Jul 2022 02:01:56 +0000 (11:01 +0900)
commit406ca8085f0f7db9620d09fa04b586419e9c3f11
tree26600e9550b3b608ad5f0749581ef676de30bbcc
parentde5d03f22509d83103b8c191fb43ddddbdad3c95
block/008: avoid _offline_cpu() call in sub-shell

The helper function _offline_cpu() sets a value to RESTORE_CPUS_ONLINE.
However, the commit bd6b882b2650 ("block/008: check CPU offline failure
due to many IRQs") put _offline_cpu() call in sub-shell, then the set
value to RESTORE_CPUS_ONLINE no longer affects function caller's
environment. This resulted in offlined CPUs not restored by _cleanup()
when the test case block/008 calls only _offline_cpu() and does not call
_online_cpu().

To fix the issue, avoid _offline_cpu() call in sub-shell. Use file
redirect to get output of _offline_cpu() instead of sub-shell execution.

Fixes: bd6b882b2650 ("block/008: check CPU offline failure due to many IRQs")
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
Link: https://lore.kernel.org/linux-block/20220703180956.2922025-1-yi.zhang@redhat.com/
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
tests/block/008